New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `ghQueueMicrotask` #2612

Merged

m-bert merged 11 commits into main from @mbert/add-microtask

Sep 28, 2023

Contributor

m-bert commented Sep 28, 2023

Description

queueMicrotask was added in react-native 0.66 (see changelog). Because we support versions from 0.64, and some of users still use older versions of react-native, we have to change how we handle microtasks in versions below 0.66.

Fixes #2505
Fixes #2484

Test plan

Tested on newly created app with react-native 0.65.1.

m-bert added 6 commits

September 28, 2023 07:52


          Add ghQueueMicrotask

c6c000a


          Change if

030e782


          Remove console.logs

eef9eaf


          Revert "Remove console.logs"

58cac0d

This reverts commit eef9eaf.


          Change to setImmediate

ae6029f


          Testing finished

aea5d3d

This was referenced Sep 28, 2023

ReferenceError: Can't find variable: queueMicrotask #2505

Closed

Issue with the package setup #2484

Closed

Can't find variable: queueMicrotask after upgrading to v3.2.0 (Android) software-mansion/react-native-reanimated#4559

Closed


          Add void to pass CI

a60459c

m-bert requested a review from j-piasecki

September 28, 2023 06:49

m-bert added 3 commits

September 28, 2023 13:08


          Change to setImmediate


          Simplify assignment

7936edf


          Change filename

2299b1b

j-piasecki reviewed

View reviewed changes

src/ghQueueMicrotask.ts Show resolved Hide resolved


          Add commentary

795f35e

m-bert requested a review from j-piasecki

September 28, 2023 12:36

j-piasecki approved these changes

View reviewed changes

m-bert merged commit a9272cf into main

1 check passed

m-bert deleted the @mbert/add-microtask branch

September 28, 2023 12:57

renovate bot referenced this pull request in valora-inc/wallet


          fix(deps): update dependency react-native-gesture-handler to ^2.13.2 (#…

d6e0fb2

…4315)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler)
| [`^2.13.1` ->
`^2.13.2`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.13.1/2.13.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.13.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.13.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.13.1/2.13.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.13.1/2.13.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-gesture-handler
(react-native-gesture-handler)</summary>

###
[`v2.13.2`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.13.2)

[Compare
Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.13.1...2.13.2)

#### 🐛 Bug fixes

- Add `ghQueueMicrotask` by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2612](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2612)

#### 👍 Improvements

- New onSwipeableOpenDragStart and onSwipeableCloseDragStart events by
[@&#8203;rampazzo1989](https://togithub.com/rampazzo1989) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2589](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2589)
- Remove jcenter by
[@&#8203;ChaseKnowlden](https://togithub.com/ChaseKnowlden) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2610](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2610)
- Add buildconfig flag for AGP8+ by
[@&#8203;pvegh](https://togithub.com/pvegh) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2599](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2599)

#### 🔢 Miscellaneous

- Update dependencies in e2e/web-tests by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2601](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2601)
- Bump [@&#8203;sideway/formula](https://togithub.com/sideway/formula)
from 3.0.0 to 3.0.1 in /FabricExample by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2605](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2605)
- Bump [@&#8203;sideway/formula](https://togithub.com/sideway/formula)
from 3.0.0 to 3.0.1 in /docs by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2602](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2602)
- Give some love to Gesture Handler docs by
[@&#8203;kacperkapusciak](https://togithub.com/kacperkapusciak) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2607](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2607)
- Fix typo in Composing gestures docs by
[@&#8203;S1D007](https://togithub.com/S1D007) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2614](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2614)
- Bump postcss from 8.4.30 to 8.4.31 in /e2e/web-tests by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2623](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2623)
- Bump postcss from 8.4.14 to 8.4.31 in /docs by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2621](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2621)
- Bump [@&#8203;sideway/formula](https://togithub.com/sideway/formula)
from 3.0.0 to 3.0.1 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2606](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2606)

#### New Contributors

- [@&#8203;rampazzo1989](https://togithub.com/rampazzo1989) made their
first contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2589](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2589)
- [@&#8203;ChaseKnowlden](https://togithub.com/ChaseKnowlden) made their
first contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2610](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2610)
- [@&#8203;pvegh](https://togithub.com/pvegh) made their first
contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2599](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2599)
- [@&#8203;S1D007](https://togithub.com/S1D007) made their first
contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2614](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2614)

**Full Changelog**:
software-mansion/react-native-gesture-handler@2.13.1...2.13.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>

m-bert mentioned this pull request

2.13.2 breaking app #2644

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet