[Web] Reset web-exclusive properties when handler is disabled. #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
commented
Aug 11, 2024
j-piasecki
reviewed
Aug 12, 2024
j-piasecki
reviewed
Aug 12, 2024
j-piasecki
approved these changes
Aug 12, 2024
latekvo
approved these changes
Aug 12, 2024
m-bert
added a commit
that referenced
this pull request
Aug 26, 2024
## Description #3041 introduced a regression - calling `updateGestureConfig` resulted in `NativeViewGestureHandler` having `touchAction: none;` even though it shouldn't. Because of that our example app didn't scroll. ## Test plan Check that example app is scrolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in this comment, it may be confusing that Gesture Handler blocks default events even if it is explicitly disabled. This PR adds styles reset when
enabledproperty changes.Currently it changes 3 things:
touch-actionto default valueuser-selectto default valueI'm not sure if I missed something. If so, please mention it in a comment.
Test plan
Tested on newly added example.