Fixes Android event dispatcher for old arch #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to software-mansion#3166, but for the old arch
m-bert
approved these changes
Oct 24, 2024
m-bert
pushed a commit
that referenced
this pull request
Oct 24, 2024
## Description This is similar to #3166, but for the old arch ## Test plan Before this change, our app failed to build with RN 0.76.0-rc.6 without the new arch enabled. With this change, it builds and runs correctly.
|
I know this is only a recent change but can there be a release cut with this in? 0.76 is currently broken. |
|
Hi @haswalt, we released it in 2.20.2 yesterday 😅 |
|
lol missed it by 2 hours. Good work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is similar to #3166, but for the old arch
Test plan
Before this change, our app failed to build with RN 0.76.0-rc.6 without the new arch enabled. With this change, it builds and runs correctly.