Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cairo-lang-macro fix null-byte panics #1677

Open
wants to merge 1 commit into
base: spr/main/34f01829
Choose a base branch
from
+3 −1
Open

cairo-lang-macro fix null-byte panics #1677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/cairo-lang-macro/src/types/conversion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ impl TokenStream {
///
/// # Safety
#[doc(hidden)]
pub fn into_stable(self) -> StableTokenStream {
pub fn into_stable(mut self) -> StableTokenStream {
// Remove 0 bytes so conversion will always work.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you managed to find out why these null bytes where there?

self.value.retain(|c| c != '\0');
let cstr = CString::new(self.value).unwrap();
StableTokenStream {
value: cstr.into_raw(),
Expand Down
Loading