Add printing details about compilation process #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkawula
commented
Oct 15, 2024
Comment on lines
+27
to
+28
| println!("Compiling Sierra to Casm using USC..."); | ||
|
|
There was a problem hiding this comment.
Because using USC almost always involves calling it by other tools, I believe that using the word "USC" here is appropriate
There was a problem hiding this comment.
I don't really think this is helpful 🤔
Maybe we should add information about what is compiled?
Right now this would just print the same text multiple times in snforge - for each contract file.
It could also add cargo-style message at the end to mark finished compiling (e.g. with time it took to compile the file).
|
@kkawula Could you please provide before/after comparison here (as screenshot)? |
|
We are moving this feature to snforge, because we are collecting USC output from stdout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foundry-rs/starknet-foundry#2403