Remove line terminators in eventType/id/data - #481
Open
magdzikk wants to merge 4 commits into
Open
Conversation
adamw
reviewed
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #480.
toStringcould emit fields the caller never set:eventTypeandidwere interpolated as-is, anddatawas split on\nonly. Since the WhatWG specification treats CRLF, a lone LF and a lone CR as line terminators, any of these in a value ended the line on the wire and the remainder was parsed by the client as a newdata,event,idorretryfield.datamay legitimately span lines, so it now splits on all three terminators, each part emitted as its owndata:line.eventTypeandidcannot span lines, so terminators are removed.