Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Harvest Plugin and Tutorial #256

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

SKernchen
Copy link
Contributor

Closes #255 .
This Feature shows a Tutorial for writing plugins for HERMES. To do that the git harvest plugin will be in another project.
Currently in https://github.com/hermes-hmc/hermes-git

@SKernchen
Copy link
Contributor Author

SKernchen commented May 7, 2024

My idea is to open a new public repository named plugins/ and add harvest-git there. Then I would like to use this plugin in the workflow source code, so HERMES would actively use it.

Update: you can't have group repos, so we decided for a name convention. Every plugins name should be hermes-plugin-{plugin name}

@led02 led02 self-requested a review May 30, 2024 07:23
Copy link
Member

@led02 led02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly formatting, but some minor (content) changes are also proposed.
There is one line that tells the wrong story...

docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
docs/source/tutorials/writing-a-plugin-for-hermes.md Outdated Show resolved Hide resolved
SKernchen and others added 2 commits August 9, 2024 09:54
Co-authored-by: Michael Meinel <michael.meinel@dlr.de>
@SKernchen
Copy link
Contributor Author

We should maybe keep the name convention hermes-plugin-git through the whole project and not change to hermes_git but to hermes_plugin_git

@SKernchen SKernchen merged commit 4637513 into develop Aug 9, 2024
3 checks passed
@SKernchen SKernchen deleted the feature/255-git-plugin-as-harvest-source branch August 9, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git Plugin as Harvest Source
2 participants