Skip to content

refactor: 검수 결과 표시를 이모지에서 텍스트로 변경 #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whqtker merged 1 commit into from
Aug 29, 2026
+5 −5
Merged

refactor: 검수 결과 표시를 이모지에서 텍스트로 변경 #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/example/solidconnection/common/discord/DiscordReviewMarker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
@Getter
public enum DiscordReviewMarker {

APPROVED("✅"),
REJECTED("❌"),
APPROVED("(승인되었습니다.)"),
REJECTED("(반려되었습니다.)"),
;

private final String value;
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/com/example/solidconnection/common/discord/DiscordNotifierTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class 검수_결과를_표시한다 {
then(discordWebhookSender).should()
.editMessage(eq(WEBHOOK_URL), eq(MESSAGE_ID), contentCaptor.capture());
String content = contentCaptor.getValue();
assertThat(content).startsWith("✅ ").contains("홍길동").contains("[개발 서버 알림입니다]");
assertThat(content).startsWith("(승인되었습니다.) ").contains("홍길동").contains("[개발 서버 알림입니다]");
}

@Test
Expand All @@ -92,8 +92,8 @@ class 검수_결과를_표시한다 {
then(discordWebhookSender).should()
.editMessage(anyString(), anyString(), contentCaptor.capture());
String content = contentCaptor.getValue();
assertThat(content).startsWith("❌ ");
assertThat(content).doesNotContain("✅");
assertThat(content).startsWith("(반려되었습니다.) ");
assertThat(content).doesNotContain("승인되었습니다");
}
}

Expand Down
Loading