ci: restrict ci workflow permissions to read-only - #86
Conversation
Set an explicit least-privilege permissions block so the workflow GITHUB_TOKEN is scoped to contents: read instead of inheriting the repository default. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
lgtm, no downsides? |
|
Right, no downsides. The workflow only checks out the repo and runs the build, so its |
|
@lxsmnsyc approved in June and nothing is failing. Is this just waiting on a merge? |
|
@arpitjain099 sorry I lost repo perms sometime between June and August (possibly by mistake), we'll resolve this. Thanks for the reminder! |
|
@lxsmnsyc please review when you have time |
|
@arpitjain099 This is already approved on my end, however like I mentioned I don't have repo perms anymore. I've also notified @ryansolid but he probably missed it couple of times. Let's wait again. |
Small hardening change: set
permissions: contents: readat the top of.github/workflows/ci.ymlso the workflow token is read-only instead of inheriting the repository default. The job only does checkout and build/test, so nothing else is required.