fix: dev toolbar throwing SourceMapConsumer import error on every dev page load - #2282
fix: dev toolbar throwing SourceMapConsumer import error on every dev page load#2282adipascu wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: ec4c822 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
40e5e97 to
83eb0b4
Compare
83eb0b4 to
c2ed103
Compare
c2ed103 to
d57077a
Compare
|
Is this good to go then? |
|
@brenelz good to go. If you'd rather drop the CommonJS dependencies from the toolbar entirely instead, I can do that as a follow-up. |
|
@adipascu if there's a good alternative for source-map processing, that would be great |
|
@lxsmnsyc There is: |
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
With the dev toolbar enabled, every dev page load throws:
source-map-jsanderror-stack-parserare CommonJS with neither anexportsnor amodulefield, so Vite serves them untransformed unless they are pre-bundled.ErrorBoundaryimportsDevToolbarstatically, so this fires on healthy pages rather than only on errors.This is a v2 regression. #1231 added both to
optimizeDepsin 2024 and every published v1 still carries it. The v2src/config/index.tsis a rewrite that never did, so every v2 release is affected,2.0.0-alpha.0through2.0.0.What is the new behavior?
Both are pre-bundled again, on the client environment, gated on
devOverlay.Other information
The
@solidjs/start >prefix is required. Both are dependencies of@solidjs/startrather than of the app, so a bare specifier does not resolve from the project root under pnpm and Vite skips the entry silently.Aside: I am currently available for web contracting or full-time work. Contact: adrian@pascu.be.