Adding custom create switch timeout for Cisco platforms #20522
Conversation
| @@ -76,6 +76,12 @@ elif [ "$platform" == "marvell" ]; then | |||
| if [[ ! -z $CREATE_SWITCH_TIMEOUT ]]; then | |||
| ORCHAGENT_ARGS+=" -t $CREATE_SWITCH_TIMEOUT" | |||
| fi | |||
| elif [ "$platform" == "cisco-8000" ]; then | |||
| ORCHAGENT_ARGS+="-m $MAC_ADDRESS" | |||
| CREATE_SWITCH_TIMEOUT=`cat $HWSKU_DIR/sai.profile | grep "createSwitchTimeout" | cut -d'=' -f 2` | |||
There was a problem hiding this comment.
could you add a comment to limit the hwsku to 8111?
There was a problem hiding this comment.
Hi Kevin, we will specify the new timeout only in the sai.profile of the 8111 hwsku in our internal platform code, so there's no need to specify that here. If ever there is a need for a higher timeout for any other hwsku, we can just add the new timeout to the sai.profile specific to that hwsku, and this code will work for that too. Specifying 8111 hwsku here will prevent that.
There was a problem hiding this comment.
@maunnikr-cisco What is the range of new timeout value? Could you provide the reason for the delay.
There was a problem hiding this comment.
The required timeout value seems to be around 75 seconds. With a buffer, 90s seems to be the appropriate time. We will be specifying this timeout in the sai.profile specific to the hwsku that needs this new timeout (8111). We don't think it's a good use of time to investigate this delay for the short term, and prefer to increase the delay for the hwsku instead, since there is no other functional impact.
Why I did it
Certain cisco platforms require longer / different orchagent switch create timeout values.
These timeout values will be specified in the platform specific sai.profile file.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)