Support reporting interface pvid #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Let SNMP can report the interface pvid.
- How I did it
Get vlan configuration from config DB, returning the vid if the port is untagged joining the vlan, return 0 if tagged joining vlan.
- How to verify it
Add unit test test_dot1q_port to verify this function
tests/test_dot1q_port.py::TestSonicMIB::test_getnextpdu PASSED [ 8%]
tests/test_dot1q_port.py::TestSonicMIB::test_getnextpdu_empty PASSED [ 9%]
tests/test_dot1q_port.py::TestSonicMIB::test_getnextpdu_exactmatch PASSED [ 9%]
tests/test_dot1q_port.py::TestSonicMIB::test_getnextpdu_lag PASSED [ 9%]
tests/test_dot1q_port.py::TestSonicMIB::test_getpdu PASSED [ 9%]
tests/test_dot1q_port.py::TestSonicMIB::test_getpdu_noinstance PASSED [ 10%]
- Description for the changelog
Support reporting interface pvid through SNMP