forked from matter-labs/block-explorer
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing schema to openapi docs #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for explorer-testnet-sophon-xyz canceled.
|
API E2E Test Results207 tests 207 ✅ 21s ⏱️ Results for commit 53d2060. ♻️ This comment has been updated with latest results. |
Unit Test Results 4 files 263 suites 11m 33s ⏱️ Results for commit 53d2060. ♻️ This comment has been updated with latest results. |
lutr0
changed the title
Add missing schema to openapi docs
feat: add missing schema to openapi docs
Nov 7, 2024
githubdoramon
approved these changes
Nov 7, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Same PR as matter-labs#311
Add type to all empty schemas, e.g.:
just find all instances of:
That's essentially saying: the type is an object, but in reality you want strings here (for example for the 'address' parameter, you want a string input for the address, not an object
Why ❔
Some parameters are missing schemas. This affects automation from partners e.g. MeritCircle
Checklist