Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] 합불페이지에 makers 전용 디자인 추가 #271

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

lydiacho
Copy link
Member

@lydiacho lydiacho commented Jul 29, 2024

Related Issue : Closes #266


🧑‍🎤 Summary

  • 서합/최합 합격 페이지에 배경 gradient, 배경logo, 강조color makers 버전 추가
  • GNB logo 메이커스 다크모드 추가

🧑‍🎤 Screenshot

image

🧑‍🎤 Comment

  • 강조컬러는 저희가 theme에서 지정해주지 않은 mds color 이길래 라이브러리 import 해서 사용해주었고,
    그라데이션컬러는 mds 컬러가 아니라서 헥사코드로 넣어두었습니다!

  • 합불 메시지도 메이커스 버전으로 수정이 필요한데, 슬랙 논의를 참고하니 앞으로 차차 정할 것 같아서 정해지는 대로 따로 이슈파서 반영하겠습니다! 일단 서류 모집 시작 전까지는 필수적인 부분은 아니어서요!

@lydiacho lydiacho self-assigned this Jul 29, 2024
Copy link

height bot commented Jul 29, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@eonseok-jeon eonseok-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 이쁘네용 :)

지금 어드민을 맘대로 조절할 순 없어 테스트를 해볼 순 없었지만 코드상에서는 문제가 없는 걸로 판단이 됩니다!

고생하셨어요 🚀

@lydiacho lydiacho merged commit 9541494 into develop Jul 29, 2024
2 checks passed
@lydiacho lydiacho deleted the design/#266_final-makers branch July 29, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] 최종 결과 페이지 색 및 로고 변경
2 participants