Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 파일 관련 필수 에러만 제거 #339

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

eonseok-jeon
Copy link
Member

Related Issue : Closes #338


🧑‍🎤 Summary

  • 에러 메세지 겹치는 에러 해결
  • key 중복되는 에러 해결

🧑‍🎤 Comment

생각보다 에러 많아서 모집 끝나고 이전 pr은 draft 해둔 상태고,
모집 기간 이후 수정해야 할 거 같아여

그래서 일단 이것들만 수정했습니다!!
코리 남겨주신 것들은 저짝 branch에서 계속 진행해 볼게여!

@eonseok-jeon eonseok-jeon linked an issue Aug 2, 2024 that may be closed by this pull request
Copy link

height bot commented Aug 2, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 동의합니다 예상치 못한 사이드이펙트가 많이 일어나는 것 같아서 잠재적 에러는 뒷단에서 천천히 처리해보는게 좋을 것 같아요!

LGTM 💯

@eonseok-jeon eonseok-jeon merged commit 02c0240 into develop Aug 2, 2024
1 check passed
@eonseok-jeon eonseok-jeon deleted the fix/#338_file-errors branch August 2, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 파일 관련 필수 에러만 제거
2 participants