Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] apply page 카테고리 관련 에러 해결 #362

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

eonseok-jeon
Copy link
Member

@eonseok-jeon eonseok-jeon commented Aug 8, 2024

Related Issue : Closes #361


🧑‍🎤 Summary

  • 리뷰 페이지에서 apply info 줄어든 만큼 category도 더 빨리 사라지도록 수정
  • 개인정보 수집 동의 여부까지 스크롤 내리면 다시 카테고리 등장하는 에러 해결
  • 카테고리 사라져도 계속 클릭되는 에러 해결

🧑‍🎤 Screenshot

리뷰 페이지에서 apply info 줄어든 만큼 category도 더 빨리 사라지도록 수정

2024-08-08.1.34.26.mov

개인정보 수집 동의 여부까지 스크롤 내리면 다시 카테고리 등장하는 에러

스크린샷 2024-08-08 오후 1 40 35

스크린샷 2024-08-08 오후 1 43 08

🧑‍🎤 Comment

원래는 scrollY가 950 이상이 되어야 사라지도록 설정이 되어 있었는데
리뷰 페이지는 apply info가 지원서 페이지보다 양이 작아
380 정도에 사라지도록 설정했습니다

@eonseok-jeon eonseok-jeon linked an issue Aug 8, 2024 that may be closed by this pull request
Copy link

height bot commented Aug 8, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@auto-assign auto-assign bot requested a review from lydiacho August 8, 2024 04:37
@eonseok-jeon eonseok-jeon marked this pull request as draft August 8, 2024 04:39
@eonseok-jeon eonseok-jeon marked this pull request as ready for review August 8, 2024 04:44
@eonseok-jeon eonseok-jeon marked this pull request as draft August 8, 2024 05:43
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Aug 8, 2024
@eonseok-jeon eonseok-jeon marked this pull request as ready for review August 8, 2024 05:50
@eonseok-jeon eonseok-jeon changed the title [Fix] 리뷰 페이지에서는 카테고리 좀 더 빨리 사라지게 만들기 [Fix] apply page 카테고리 관련 에러 해결 Aug 8, 2024
Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 ~~~ :)

@eonseok-jeon eonseok-jeon merged commit 8411275 into develop Aug 8, 2024
@eonseok-jeon eonseok-jeon deleted the fix/#361_review-category branch August 8, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] apply page 카테고리 관련 에러 해결
2 participants