Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Mobile ver. - Dialog 구현 #392

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

eonseok-jeon
Copy link
Member

Related Issue : Closes #377


🧑‍🎤 Summary

  • dialog들 반응형으로 구현
  • dialog들 import 방식 통일

🧑‍🎤 Screenshot

ExitDialog

스크린샷 2024-08-13 오후 5 58 34

SubmitDialog

스크린샷 2024-08-13 오후 5 56 42

SessionExpiredDialog

스크린샷 2024-08-13 오후 5 55 06

PreventReviewDialog

스크린샷 2024-08-13 오후 5 54 53

PreventApplyDialog

스크린샷 2024-08-13 오후 5 54 34

ExistingApplicantDialog

스크린샷 2024-08-13 오후 5 53 44

DraftDialog

스크린샷 2024-08-13 오후 5 53 36

CompleteDialog

스크린샷 2024-08-13 오후 5 53 29

🧑‍🎤 Comment

dialog들 import 방식 통일

몇 개는 해당 컴포넌트에서 import 되고 있어서
기존 방식인 index.tsx에서 한 번에 import 해주는 방식으로 통일했어요

export { default as CompleteDialog } from './CompleteDialog';
export { default as DraftDialog } from './DraftDialog';
export { default as ExistingApplicantDialog } from './ExistingApplicantDialog';
export { default as ExitDialog } from './ExitDialog';
export { default as PreventApplyDialog } from './PreventApplyDialog';
export { default as PreventReviewDialog } from './PreventReviewDialog';
export { default as SessionExpiredDialog } from './SessionExpiredDialog';
export { default as SubmitDialog } from './SubmitDialog';

@eonseok-jeon eonseok-jeon linked an issue Aug 13, 2024 that may be closed by this pull request
Copy link

height bot commented Aug 13, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 없는거 확인했습니다 :)
고생하셨습니다!!

@eonseok-jeon eonseok-jeon merged commit 3179b95 into develop Aug 14, 2024
1 check passed
@eonseok-jeon eonseok-jeon deleted the design/#377_mobile-dialogs branch August 14, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] Mobile ver. - Dialog 구현
2 participants