Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] meta tag && 연산자 삭제 #403

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[Fix] meta tag && 연산자 삭제 #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta property="og:type" content="website" />
<meta property="og:locale" content="ko_KR" />
<meta property="og:url" content="https://recruiting.sopt.org" />
<meta property="twitter:site" content="https://recruiting.sopt.org" />
</head>
<body>
<div id="modal"></div>
Expand Down
10 changes: 7 additions & 3 deletions src/common/components/Layout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,15 @@ const Head = () => {
const TOUCH_ICON = isMakers ? '/makers-touch-icon.png' : '/apple-touch-icon.png';
const ICON = isMakers ? '/makersIcon.svg' : '/icon.svg';
const FAVICON = isMakers ? '/makersFavicon.ico' : '/favicon.ico';
const SITE_NAME = isMakers === undefined ? 'SOPT 리크루팅' : `SOPT ${isMakers && 'makers '}리크루팅`;
const TITLE = season === undefined ? 'SOPT 모집 지원하기' : `SOPT ${isMakers && 'makers '}${season}기 모집 지원하기`;
const SITE_NAME = isMakers === undefined ? 'SOPT 리크루팅' : `SOPT ${isMakers ? 'makers ' : ''}리크루팅`;
const TITLE =
season === undefined ? 'SOPT 모집 지원하기' : `SOPT ${isMakers ? 'makers ' : ''}${season}기 모집 지원하기`;
const IMAGE = isMakers ? '/makersOg.png' : '/imgOg.png';
const DESCRIPTION =
isMakers === undefined
? `SOPT의 신입 기수 모집페이지입니다.`
: `SOPT${isMakers && ' makers'}의 신입 기수 모집페이지입니다.`;
: `SOPT${isMakers ? ' makers' : ''}의 신입 기수 모집페이지입니다.`;
const URL = isMakers ? 'https://recruiting.sopt.org' : 'https://recruit.sopt.org';

return (
<Helmet>
Expand All @@ -34,6 +36,7 @@ const Head = () => {
<meta property="og:title" content={TITLE} />
<meta property="og:description" content={DESCRIPTION} />
<meta property="og:site_name" content={SITE_NAME} />
<meta property="og:url" content={URL} />

<meta property="og:image" content={IMAGE} />
<meta property="og:image:alt" content={SITE_NAME} />
Expand All @@ -45,6 +48,7 @@ const Head = () => {
<meta name="twitter:description" content={DESCRIPTION} />
<meta name="twitter:image" content={IMAGE} />
<meta property="twitter:image:alt" content={SITE_NAME} />
<meta property="twitter:site" content={URL} />

<title>{TITLE}</title>
<meta name="author" content="sopt makers team official 4th" />
Expand Down