Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] ReviewPage 클릭 비활성화 처리 #404

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

lydiacho
Copy link
Member

Related Issue : Closes #381


🧑‍🎤 Summary

ReviewPage에서 click 및 hover 비활성화 처리가 누락되어있는 부분들이 있어서 마저 처리해주었습니다.

🧑‍🎤 Screenshot

  • Radio
2024-08-16.8.38.17.mov
  • CheckBox
2024-08-16.8.37.55.mov

🧑‍🎤 Comment

동적 metatag pre-render 이슈는 생각보다 더 오래 걸릴 것 같아서 중간에 멈추고 자잘한 버그픽스부터 하려고 해요! ㅠㅠ

cursor도 not-allowed로 바꿔주고, hover 했을 때 색 달라지는 것도 disabled의 느낌을 방해한다고 생각해서 hover 조건에 enabled (disabled 아닐 때) 도 추가해주었어요!

Copy link

height bot commented Aug 16, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@lydiacho lydiacho merged commit 85ade7f into develop Aug 16, 2024
1 check passed
@lydiacho lydiacho deleted the fix/#381_review-checkbox branch August 16, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] ReviewPage checkbox disabled 처리
1 participant