[Refactor] 번들 크기 개선 - 2 #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
lydiacho
approved these changes
Aug 29, 2024
| @@ -122,7 +122,7 @@ const FinalResult = () => { | |||
| <div style={{ overflow: 'auto', height: '100%' }}> | |||
| <div className={contentWrapperVar[deviceType]}> | |||
| <Title>결과 확인</Title> | |||
| <Content pass={pass} /> | |||
| <Content pass={true} /> | |||
eonseok-jeon
force-pushed
the
refactor/#431_bundle-size-2
branch
from
c145a69
to
fc0b814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue : Closes #431
🧑🎤 Summary
🧑🎤 Screenshot
개선된 건 PR 3에서 확인할 수 있어요
🧑🎤 Comment
😈 date-fns import 범위 축소
필요 없는 부분들 까지 같이 import 되고 있더라고요?
예를 들어 ko가 아닌 다른 나라 locale 등등
정말 필요한 부분만 import 되도록 범위 수정해 줬어요
사실 그렇다할 유의미한 차이(0.01kb 감소)는 없었는데요 build 시간을 조금 단축(0.5s 단축)할 수 있었어요
