Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] context provider를 컴포넌트로 분리 #437

Merged
merged 11 commits into from
Aug 28, 2024

Conversation

eonseok-jeon
Copy link
Member

Related Issue : Closes #436


🧑‍🎤 Summary

  • context provider를 컴포넌트로 분리 (관심사 분리)
  • 해당 context와 관련된 코드들 분리 및 같은 파일에서 관리

🧑‍🎤 Comment

😓 기존

  • App.tsx 내에서 모든 context 관리하고 있었음
  • 사용처에서 매번 useContext와 Context를 import 해와야 함

🥳 변경 후

  • context는 각각의 파일에서 관리
  • custom hook으로 분리하여 해당 hook을 import 함

@eonseok-jeon eonseok-jeon linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link

height bot commented Aug 28, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provider 분리 너무 좋습니다 ~~
고생하셨습니두 👍👍👍👍

@eonseok-jeon eonseok-jeon merged commit b99be93 into develop Aug 28, 2024
1 check passed
@eonseok-jeon eonseok-jeon deleted the refactor/#436_context-provider branch August 28, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] context provider를 컴포넌트로 분리
2 participants