Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP2] 메인페이지 모집알림신청 버튼 QA #297

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

SeojinSeojin
Copy link
Member

Summary

  • 모집 알림 신청 버튼에서 마우스 진입 시 생기는 동동이가 서서히 뜨도록 변경합니다
  • 그 때 글씨도 살짝쿵 작아지도록 변경합니다.

Screenshot

2023-11-26.5.20.12.mov

Comment

  • 원래 동동이를 background-image로 띄웠으나, 그러면 서서히 밝아지는 효과가 적용되지 않아서
  • before 속성으로 바꾸고 opacity에 transition을 주는 방식으로 변경하였습니다!!!!!!

Copy link
Contributor

@f0rever0 f0rever0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 QA 작업 고생하셨습니당 !!

Comment on lines +59 to +73
background-image: radial-gradient(
circle 36px at ${(props) => props.x}px ${(props) => props.y}px,
#3e5e7d90,
transparent
),
radial-gradient(
circle 80px at ${(props) => props.x}px ${(props) => props.y}px,
#3e5e7d50,
transparent
),
radial-gradient(
circle 108px at ${(props) => props.x}px ${(props) => props.y}px,
#3e5e7d50,
transparent
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 기존 코드 처럼 x.y를 구조분해할당으로 받아서 코드 작성은 안되나요?

background-image: ${({ x, y }) =>
      `radial-gradient(circle 36px at ${x}px ${y}px, #3E5E7D90, transparent),
       radial-gradient(circle 80px at ${x}px ${y}px, #3E5E7D50, transparent),
       radial-gradient(circle 108px at ${x}px ${y}px, #3E5E7D50, transparent)`};

Copy link
Member

@solar3070 solar3070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고입니다!! 고생하셨어요 👍

@SeojinSeojin SeojinSeojin merged commit 8fd76fb into develop Nov 27, 2023
1 check passed
@SeojinSeojin SeojinSeojin deleted the fix/#296_main-recruit_button-delay branch November 27, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants