Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP0] 메인페이지 QA 반영 #384

Merged
merged 12 commits into from
Mar 26, 2024
Merged

[SP0] 메인페이지 QA 반영 #384

merged 12 commits into from
Mar 26, 2024

Conversation

eonseok-jeon
Copy link
Member

@eonseok-jeon eonseok-jeon commented Mar 26, 2024

Summary

close #383

파트별 설명 교체는 아직 디자인이 나오지 않아 그대로 냅뒀습니다.
근데 어차피 이건 워딩 수정이라 코리 필요 없을 거 같아 일단 먼저 pr 올려요~

review section에서 1580px 정도 이하가 되면
스크린샷 2024-03-26 오전 9 49 12

이런 식으로 겹치는 오류 생겨서
break-point 넉넉하게 1600으로 수정했습니다.

수정된 건

  • 워딩 수정
  • review section 글자 겹치는 오류 해결
  • ui 수정
    입니다.

그 승희 commit도 따라온 이유는,,
error page 코리 달려고 branch 이동했다가
까먹고 fix/#383_modify_qa로 다시 이동하지 않은채 개발 진행해서 그렇습니다.
하는 수 없이 error page branch -> main page branch로 merge 해줬거든요,, 큼큼,,;
죄송해유
코리 달리고 워딩 수정 되면은 squash merge 진행하겠습니다.

@eonseok-jeon eonseok-jeon added this to the 4기 milestone Mar 26, 2024
@eonseok-jeon eonseok-jeon self-assigned this Mar 26, 2024
@eonseok-jeon eonseok-jeon linked an issue Mar 26, 2024 that may be closed by this pull request
2 tasks
Copy link

height bot commented Mar 26, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 26, 2024
Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 좋네용 수고 많으셨습니다!

다른 브랜치에서 실수로 작업 진행한 경험 저도 겪었었는데요 ㅋ ㅋ ㅋ

  • push를 아직 하지 않고 커밋만 찍은 상황이라면? -> git cherry-pick 사용해주기
  • push를 해버렸다면? ->
스크린샷 2024-03-26 17 09 35 요런 노가다 방식도 있답니다

참고참고~~!

src/lib/types/main.ts Show resolved Hide resolved
@eonseok-jeon eonseok-jeon merged commit 6a4f062 into develop Mar 26, 2024
1 check passed
@eonseok-jeon eonseok-jeon deleted the fix/#383_modify_qa branch March 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SP0] 메인페이지 QA 반영
2 participants