Merge branch 'mvaneijken-master' into v2022-0920

sorengranfeldt · Sep 20, 2022 · c0066ca · c0066ca
2 parents 73b4157 + 9b74b0b
commit c0066ca
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/Granfeldt.SQL.MA/SqlMethods/SqlMethods.Impersonation.cs b/Granfeldt.SQL.MA/SqlMethods/SqlMethods.Impersonation.cs
@@ -202,8 +202,20 @@ void ShowIdentity()
                     {
                         foreach (IdentityReference group in currentIdentity.Groups)
                         {
-                            NTAccount account = group.Translate(typeof(NTAccount)) as NTAccount;
-                            Tracer.TraceInformation("group-membership {0}", account.Value);
+                            try
+                            {
+                                NTAccount account = group.Translate(typeof(NTAccount)) as NTAccount;
+                                Tracer.TraceInformation("group-membership {0}", account.Value);
+                            }
+                            catch (Exception ex)
+                            {
+                                /*
+								 * If the SID cannot be resolved, log the SID, but don't throw the exception.
+								 * Throwing the exception kills the run profile, where the membership might be totally
+								 * irrelevant. We do log the SID for diagnostic purpose.
+								 */
+                                Tracer.TraceError($"error-resolving-current-group-name: {group.Value}", ex);
+                            }
                         }
                     }
                 }