Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restruct the code to use soroush pacakge #3

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

alinik
Copy link
Contributor

@alinik alinik commented Oct 25, 2018

No description provided.

@alinik alinik mentioned this pull request Oct 25, 2018
@iranpak
Copy link
Collaborator

iranpak commented Nov 21, 2018

Hi.
Thanks for your contributing.
First of all, could you rename its pypi package to SoroushBot?

@alinik
Copy link
Contributor Author

alinik commented Nov 22, 2018

Seems it's impossible to rename a package. but we can create new one and modify last release of this version to redirect to new package.
If it's fine for you, let me know to do it.

@iranpak
Copy link
Collaborator

iranpak commented Nov 26, 2018

Yes, it seems good. and what about versioning and update package based on this repository? what is its mechanism?

@alinik
Copy link
Contributor Author

alinik commented Nov 27, 2018

you have to change the code structure to what I recommend. so we can use make file to create and upload new version

@iranpak
Copy link
Collaborator

iranpak commented Dec 1, 2018

So let's go. What should i do know?

@alinik
Copy link
Contributor Author

alinik commented Dec 2, 2018 via email

@iranpak
Copy link
Collaborator

iranpak commented Dec 6, 2018

OK.

@iranpak
Copy link
Collaborator

iranpak commented Dec 16, 2018

So what happened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants