Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to enable CORS #50

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Feature to enable CORS #50

merged 3 commits into from
Aug 5, 2023

Conversation

harshadk-sourcefuse
Copy link
Contributor

@harshadk-sourcefuse harshadk-sourcefuse commented Aug 2, 2023 •
edited
Loading

Description

Added the feature to enable the CORS
To enable CORS on url you need to simply add cors.url in application properties file
check below example

cors.url=http://localhost:4200

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@harshadk-sourcefuse harshadk-sourcefuse added the enhancement New feature or request label Aug 2, 2023
@harshadk-sourcefuse harshadk-sourcefuse self-assigned this Aug 2, 2023
@mlakdawala-sf mlakdawala-sf merged commit 64cc4d0 into master Aug 5, 2023
1 check passed
@mlakdawala-sf mlakdawala-sf deleted the cors-feature branch August 5, 2023 09:47
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlakdawala-sf mlakdawala-sf mlakdawala-sf approved these changes

Assignees

@harshadk-sourcefuse harshadk-sourcefuse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshadk-sourcefuse @mlakdawala-sf