Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kotlin + compiler api dependency to 1.8.21 #56

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

Strum355
Copy link
Contributor

@Strum355 Strum355 commented May 4, 2023

Buncha deprecation warnings, do we leave versions pre 1.8.21 behind to move to non-deprecated stuff? (see e.g.: https://sourcegraph.com/github.com/JetBrains/kotlin/-/commit/8b42638afa00626078aa7d04ea62a129f0323cdc)

Test plan

Unit tests 😊

@Strum355 Strum355 requested review from keynmol and olafurpg May 4, 2023 20:54
@Strum355 Strum355 self-assigned this May 4, 2023
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we leave versions pre 1.8.21 behind to move to non-deprecated stuff?

Given the limited usage this plugin gets, I think it's fine to move forward and recommend using an older version of this plugin for users who are not able to upgrade to the latest Kotlin.

@Strum355 Strum355 merged commit 8046eab into main Jul 20, 2023
@keynmol keynmol deleted the nsc/kotlin-1.8 branch July 20, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants