emit overridden_symbols for Go to Implementations #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this repo had custom logic to snapshot the generated SemanticDB files, which was missing some SCIP features like relationships. This commit replaces the custom snapshot logic with the `scip-java snapshot` command, which prints all SCIP features including symbol relationships.
olafurpg
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
LGTM 👍🏻 I updated the snapshot infrastructure to reuse the logic from scip-java. I didn't figure out how to preserve the shorter paths relative to the source directories, but figured it wouldn't reduce the diff size so much because all symbol occurrences are a different syntax anywaays (they include the semanticdb maven . . prefix).
|
Will follow up at a later time with support for typealiases. Current behaviour is that the underlying type is added as an implementation, not the typealias and the underlying. Need to investigate what gets emitted for type aliases too, as it may be the underlying instead of a unique symbol for the typealias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emits semanticdb
overridden_symbolsfor class-like and method declarationsTest plan
Green CI with updated snapshot tests that include implementation relationships.