Upgrade to Kotlin 1.9.x #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sourcegraph#74. My limited understanding of Kotlin compiler compatibility is that this change drops support for 1.8.x. Until we move to the more stable Kotlin compiler API (which I have barely researched), I think it's reasonable to target the latest Kotlin version in scip-kotlin. Users on older versions of Kotlin will need to stay on older versions of scip-kotlin.
olafurpg
commented
Feb 2, 2024
| | Kotlin version | scip-kotlin version | | ||
| |----------------|---------------------| | ||
| | 1.8.x | 0.3.2 | | ||
| | 1.9.x | 0.4.0 | |
There was a problem hiding this comment.
0.4.0 is not released yet but I can cut it after we merge this PR
keynmol
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74. My limited understanding of Kotlin compiler compatibility is that this change drops support for 1.8.x. Until we move to the more stable Kotlin compiler API (which I have barely researched), I think it's reasonable to target the latest Kotlin version in scip-kotlin. Users on older versions of Kotlin will need to stay on older versions of scip-kotlin.
Test plan
Green CI.