Skip to content

Commit

Permalink
fix: test (#1010)
Browse files Browse the repository at this point in the history
  • Loading branch information
richardtreier authored Jul 24, 2024
1 parent 8aa7143 commit 8b56e99
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 11 deletions.
1 change: 1 addition & 0 deletions extensions/contract-termination/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ dependencies {
testImplementation(project(":utils:test-utils"))
testImplementation(project(":utils:versions"))

testImplementation(libs.edc.monitorJdkLogger)
testImplementation(libs.edc.http) {
exclude(group = "org.eclipse.jetty", module = "jetty-client")
exclude(group = "org.eclipse.jetty", module = "jetty-http")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@
import org.junit.jupiter.api.extension.ExtendWith;

import java.time.OffsetDateTime;
import java.time.temporal.ChronoUnit;

import static de.sovity.edc.ext.db.jooq.enums.ContractTerminatedBy.COUNTERPARTY;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.within;

@ExtendWith(E2eTestExtension.class)
class TerminateContractQueryTest {
Expand Down Expand Up @@ -77,7 +79,7 @@ void terminateConsumerAgreementOrThrow_shouldInsertRowInTerminationTable(
assertThat(detailsAfterTermination.consumerAgentId()).isEqualTo("consumer");
assertThat(detailsAfterTermination.reason()).isEqualTo("Some reason");
assertThat(detailsAfterTermination.detail()).isEqualTo("Some detail");
assertThat(detailsAfterTermination.terminatedAt()).isBetween(now, now.plusSeconds(1));
assertThat(detailsAfterTermination.terminatedAt()).isCloseTo(now, within(2, ChronoUnit.SECONDS));
assertThat(detailsAfterTermination.terminatedBy()).isEqualTo(COUNTERPARTY);
}
);
Expand Down
2 changes: 1 addition & 1 deletion extensions/wrapper/clients/java-client/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public class WrapperClientExample {
```java
import de.sovity.edc.client.EdcClient;
import de.sovity.edc.client.gen.model.KpiResult;
import de.sovity.edc.client.oauth2.OAuth2ClientCredentials;
import de.sovity.edc.client.oauth2.Oauth2ClientCredentials;
import de.sovity.edc.client.oauth2.SovityKeycloakUrl;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import org.mockserver.integration.ClientAndServer;

import static de.sovity.edc.e2e.AlwaysTrueMigrationTest.testTransfer;
import static org.assertj.core.api.Assertions.assertThat;

class AlwaysTrueMigrationTestReversed {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import org.mockserver.model.HttpResponse;

import java.time.OffsetDateTime;
import java.time.temporal.ChronoUnit;
import java.util.List;
import java.util.Map;
import java.util.stream.IntStream;
Expand All @@ -54,6 +55,7 @@
import static java.time.Duration.ofSeconds;
import static java.util.concurrent.TimeUnit.SECONDS;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.within;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.DynamicTest.dynamicTest;

Expand Down Expand Up @@ -449,7 +451,7 @@ private static void assertTermination(
assertThat(consumerInformation).isNotNull();

val now = OffsetDateTime.now();
assertThat(consumerInformation.getTerminatedAt()).isBetween(now.minusMinutes(1), now.plusMinutes(1));
assertThat(consumerInformation.getTerminatedAt()).isCloseTo(now, within(1, ChronoUnit.MINUTES));

assertThat(consumerInformation.getDetail()).isEqualTo(detail);
assertThat(consumerInformation.getReason()).isEqualTo(reason);
Expand Down
4 changes: 0 additions & 4 deletions utils/test-utils/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,8 @@ dependencies {
api(project(":extensions:wrapper:clients:java-client"))
api(project(":utils:json-and-jsonld-utils"))

implementation(project(":extensions:policy-always-true"))
implementation(project(":extensions:postgres-flyway"))
implementation(project(":utils:versions"))
implementation(libs.edc.jsonLdSpi)
implementation(libs.edc.jsonLd)
implementation(libs.edc.sqlCore)
implementation(libs.assertj.core)
implementation(libs.jooq.jooq)
implementation(libs.mockserver.netty)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import java.util.stream.Stream;

import static de.sovity.edc.extension.e2e.connector.config.ConnectorConfigFactory.forTestDatabase;
import static de.sovity.edc.extension.postgresql.PostgresFlywayExtension.EDC_FLYWAY_ADDITIONAL_MIGRATION_LOCATIONS;
import static org.eclipse.edc.junit.testfixtures.TestUtils.getFreePort;
import static org.mockserver.stop.Stop.stopQuietly;

Expand Down Expand Up @@ -85,7 +84,7 @@ public E2eTestExtension(
"consumer",
testDatabase -> {
consumerConfig = forTestDatabase(this.consumerParticipantId, testDatabase);
consumerConfig.getProperties().put(EDC_FLYWAY_ADDITIONAL_MIGRATION_LOCATIONS, this.additionalConsumerMigrationLocation);
consumerConfig.getProperties().put("edc.flyway.additional.migration.locations", this.additionalConsumerMigrationLocation);
return consumerConfig.getProperties();
}
);
Expand All @@ -94,7 +93,7 @@ public E2eTestExtension(
"provider",
testDatabase -> {
providerConfig = forTestDatabase(this.providerParticipantId, testDatabase);
providerConfig.getProperties().put(EDC_FLYWAY_ADDITIONAL_MIGRATION_LOCATIONS, this.additionalProviderMigrationLocation);
providerConfig.getProperties().put("edc.flyway.additional.migration.locations", this.additionalProviderMigrationLocation);
return providerConfig.getProperties();
}
);
Expand Down

0 comments on commit 8b56e99

Please sign in to comment.