Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating transfer history page to api wrapper #421

Merged
merged 33 commits into from
Jul 25, 2023
Merged

Migrating transfer history page to api wrapper #421

merged 33 commits into from
Jul 25, 2023

Conversation

AnurosePrakash
Copy link
Contributor

@AnurosePrakash AnurosePrakash commented Jul 11, 2023 •
edited
Loading

Pull Request

Migrating transfer history page to api wrapper

How Has This Been Tested?

With mock tests

PR is blocked by

Checklist

  • I have formatted the title correctly and precisely
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and public classes/methods
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings (performed checkstyle check locally)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have added/updated copyright headers

AnurosePrakash and others added 13 commits July 3, 2023 17:31
@AnurosePrakash
feat: Updating the data fetcher of new TransferHistoryEntry Model (WIP)
6805dd0
@AnurosePrakash
chore: added the TransferHistoryPageApiService
b8a0446
@AnurosePrakash
chore: building tests for new transfer history page api wrapper
37d180b
@AnurosePrakash
chore: building tests for new transfer history page api wrapper (WIP)
e380f07
@AnurosePrakash
chore: tests updated for new transfer history page api wrapper
9208e11
@AnurosePrakash
Merge branch 'main' into Migrating_transfer_history_page_to_API_wrapper
2e7a76b
@AnurosePrakash
chore: implemented GetTransferProcessAssetApiServiceTest
aed81ee
@AnurosePrakash
chore: reformatting - removing unwanted blank lines
702d012
@richardtreier @AnurosePrakash
chore: prepare release (#414)
7fdd65f
@dependabot @AnurosePrakash
build(deps): bump io.swagger.core.v3:swagger-annotations-jakarta (#417)
33c26c9 
Bumps io.swagger.core.v3:swagger-annotations-jakarta from 2.2.14 to 2.2.15.

---
updated-dependencies:
- dependency-name: io.swagger.core.v3:swagger-annotations-jakarta
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @AnurosePrakash
build(deps): bump io.swagger.core.v3:swagger-jaxrs2-jakarta (#416)
afe9e32 
Bumps io.swagger.core.v3:swagger-jaxrs2-jakarta from 2.2.14 to 2.2.15.

---
updated-dependencies:
- dependency-name: io.swagger.core.v3:swagger-jaxrs2-jakarta
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @AnurosePrakash
build(deps): bump gradle/gradle-build-action from 2.5.1 to 2.6.0 (#419)
85ee014 
Bumps [gradle/gradle-build-action](https://github.com/gradle/gradle-build-action) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/gradle/gradle-build-action/releases)
- [Commits](gradle/gradle-build-action@40b6781...bd57605)

---
updated-dependencies:
- dependency-name: gradle/gradle-build-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AnurosePrakash
Merge remote-tracking branch 'origin/main'
6dc65df 
# Conflicts:
#	extensions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/UiResource.java
richardtreier
richardtreier reviewed Jul 11, 2023
View reviewed changes
...wrapper/client/src/test/java/de/sovity/edc/client/GetTransferProcessAssetApiServiceTest.java Outdated Show resolved Hide resolved
...wrapper/client/src/test/java/de/sovity/edc/client/GetTransferProcessAssetApiServiceTest.java Outdated Show resolved Hide resolved
...wrapper/client/src/test/java/de/sovity/edc/client/GetTransferProcessAssetApiServiceTest.java Show resolved Hide resolved
...ons/wrapper/client/src/test/java/de/sovity/edc/client/TransferHistoryPageApiServiceTest.java Outdated Show resolved Hide resolved
...ons/wrapper/client/src/test/java/de/sovity/edc/client/TransferHistoryPageApiServiceTest.java Outdated Show resolved Hide resolved
...a/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferHistoryPageDataFetcher.java Outdated Show resolved Hide resolved
...a/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferHistoryPageDataFetcher.java Outdated Show resolved Hide resolved
...a/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferHistoryPageDataFetcher.java Outdated Show resolved Hide resolved
...java/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferProcessAssetFetcher.java Outdated Show resolved Hide resolved
...java/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferProcessAssetFetcher.java Outdated Show resolved Hide resolved
@AnurosePrakash
chore: reformatting - refactoring method calls
1018a85
@AnurosePrakash
Merge remote-tracking branch 'origin/Migrating_transfer_history_page_…
2f3544b 
…to_API_wrapper' into Migrating_transfer_history_page_to_API_wrapper

# Conflicts:
#	extensions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/UiResource.java
richardtreier
richardtreier reviewed Jul 12, 2023
View reviewed changes
...wrapper/client/src/test/java/de/sovity/edc/client/GetTransferProcessAssetApiServiceTest.java Outdated Show resolved Hide resolved
...wrapper/client/src/test/java/de/sovity/edc/client/GetTransferProcessAssetApiServiceTest.java Outdated Show resolved Hide resolved
...ons/wrapper/client/src/test/java/de/sovity/edc/client/TransferHistoryPageApiServiceTest.java Outdated Show resolved Hide resolved
extensions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/UiResource.java Outdated Show resolved Hide resolved
...va/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferHistoryPageApiService.java Show resolved Hide resolved
...a/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferHistoryPageDataFetcher.java Outdated Show resolved Hide resolved
...a/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferHistoryPageDataFetcher.java Outdated Show resolved Hide resolved
...a/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferHistoryPageDataFetcher.java Outdated Show resolved Hide resolved
...e/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferProcessGetAssetApiService.java Outdated Show resolved Hide resolved
SaadEGI
SaadEGI suggested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@SaadEGI SaadEGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline Red?

@AnurosePrakash AnurosePrakash marked this pull request as draft July 25, 2023 11:27
@AnurosePrakash AnurosePrakash marked this pull request as ready for review July 25, 2023 11:32
@AnurosePrakash AnurosePrakash removed the request for review from richardtreier July 25, 2023 12:25
@efiege efiege merged commit 8438245 into main Jul 25, 2023
12 checks passed
@efiege efiege deleted the Migrating_transfer_history_page_to_API_wrapper branch July 25, 2023 12:56
@AnurosePrakash AnurosePrakash linked an issue Jul 28, 2023 that may be closed by this pull request
Migrate Transfer History Page to API Wrapper sovity/edc-ui#231
Closed
10 tasks
@richardtreier richardtreier mentioned this pull request Aug 11, 2023
Closed
ununhexium added a commit that referenced this pull request May 2, 2024
@ununhexium
feat: Use stable contract offer ID (#421)
769846b 
Co-authored-by: Christophe Loiseau <christophe.loiseau@sovity.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtreier richardtreier richardtreier left review comments

@SaadEGI SaadEGI SaadEGI approved these changes

@efiege efiege efiege approved these changes

Assignees

@AnurosePrakash AnurosePrakash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Transfer History Page to API Wrapper
5 participants
@AnurosePrakash @SaadEGI @richardtreier @efiege @SebastianOpriel