chore: minor refactorings with function namings and variable types

sovity · Aug 11, 2023 · 3db34f3 · 3db34f3
1 parent e06992f
commit 3db34f3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/app/core/services/asset-entry-builder.ts b/src/app/core/services/asset-entry-builder.ts
@@ -21,7 +21,7 @@ export class AssetEntryBuilder {
    * @param formValue form value
    * @return asset create dto
    */
-  buildAssetEntry(formValue: AssetEditorDialogFormValue): AssetCreateRequest {
+  buildAssetCreateRequest(formValue: AssetEditorDialogFormValue): AssetCreateRequest {
     let properties = this.assetPropertyMapper.buildProperties(formValue);
     const dataAddressProperties = this.dataAddressMapper.buildDataAddressProperties(
       formValue.datasource,

diff --git a/src/app/routes/connector-ui/asset-page/asset-create-dialog/asset-create-dialog.component.ts b/src/app/routes/connector-ui/asset-page/asset-create-dialog/asset-create-dialog.component.ts
@@ -39,7 +39,8 @@ export class AssetCreateDialogComponent implements OnDestroy {
 
   onSave() {
     const formValue = this.form.value;
-    const assetEntry = this.assetEntryBuilder.buildAssetEntry(formValue);
+    const assetEntry =
+      this.assetEntryBuilder.buildAssetCreateRequest(formValue);
 
     this.form.all.disable();
     this.loading = true;

diff --git a/...t-page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog.component.ts b/...t-page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog.component.ts
@@ -139,11 +139,7 @@ export class ContractAgreementTransferDialogComponent implements OnDestroy {
         value,
       );
 
-    let dataSinkProperties =
-      {
-        properties:
-          this.dataAddressMapper.buildDataAddressProperties(value).properties,
-      } ?? {};
+    let dataSinkProperties = this.dataAddressMapper.buildDataAddressProperties(value) ?? {};
 
     return {
       type: 'PARAMS_ONLY',