Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Dashboard chart colors based on theme #336

Closed
wants to merge 19 commits into from
Closed

Fix: Dashboard chart colors based on theme #336

wants to merge 19 commits into from

Conversation

AnurosePrakash
Copy link

@AnurosePrakash AnurosePrakash commented Jun 28, 2023 •
edited
Loading

Pull Request

Fix Dashboard chart colors based on theme

How Has This Been Tested?

Fake Backend

PR is blocked by

Checklist

  • I have formatted the title correctly and precisely
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and public classes/methods
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings (performed checkstyle check locally)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have added/updated copyright headers

@AnurosePrakash AnurosePrakash linked an issue Jun 28, 2023 that may be closed by this pull request
Fix chart colors #106
Open
5 tasks
@AnurosePrakash AnurosePrakash self-assigned this Jun 28, 2023
@richardtreier richardtreier requested a review from efiege July 4, 2023 14:28
@richardtreier richardtreier enabled auto-merge (squash) July 4, 2023 14:29
@richardtreier
Copy link
Collaborator

richardtreier commented Jul 4, 2023 •
edited
Loading

image

@AnurosePrakash AnurosePrakash marked this pull request as draft July 28, 2023 10:52
auto-merge was automatically disabled July 28, 2023 10:52

Pull request was converted to draft

AnurosePrakash and others added 11 commits August 8, 2023 16:51
@AnurosePrakash
Fix: Dashboard chart colors based on theme
69d15d4
@AnurosePrakash
chore: updated the dashboard chart colors with data from app-config
167efea
@richardtreier @AnurosePrakash
chore: fixed swapped colours and slightly reduced yellow intensity (m…
801d841 
…ds chart colours)
@richardtreier @AnurosePrakash
fix: make colours yellow
de91738
@AnurosePrakash
chore: added border color to dashboard donut charts
46a6b53
@AnurosePrakash
Merge remote-tracking branch 'origin/106-fix-chart-colors' into 106-f…
649bfc4 
…ix-chart-colors

# Conflicts:
#	CHANGELOG.md
@AnurosePrakash
chore: updated the mat-button for readability and border
42ba974
@AnurosePrakash
Merge remote-tracking branch 'remotes/origin/main' into 106-fix-chart…
4dbf8f8 
…-colors

# Conflicts:
#	src/app/routes/connector-ui/dashboard-page/dashboard-page/dashboard-page-data.service.ts
@AnurosePrakash
chore: adding border color
d799a67
@AnurosePrakash
Merge branch 'main' into 106-fix-chart-colors
3e23c0b
@AnurosePrakash
chore: Updating CHANGELOG.md
f554622
@AnurosePrakash AnurosePrakash marked this pull request as ready for review August 14, 2023 09:31
@AnurosePrakash AnurosePrakash marked this pull request as draft August 14, 2023 09:58
@efiege efiege removed their request for review October 25, 2023 07:33
@richardtreier
Copy link
Collaborator

Closed as out of date. We still haven't found good colours, so we'll leave it be for now.

@tmberthold tmberthold deleted the 106-fix-chart-colors branch May 16, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtreier richardtreier Awaiting requested review from richardtreier

Assignees

@AnurosePrakash AnurosePrakash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix chart colors
2 participants
@AnurosePrakash @richardtreier