Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize Connector Status #346

Merged
merged 12 commits into from
Jul 12, 2023
Merged

Conversation

SaadEGI
Copy link

@SaadEGI SaadEGI commented Jul 7, 2023

@SaadEGI SaadEGI linked an issue Jul 7, 2023 that may be closed by this pull request
3 tasks
@SaadEGI SaadEGI enabled auto-merge (squash) July 7, 2023 09:32
@SaadEGI SaadEGI disabled auto-merge July 7, 2023 09:32
@SaadEGI SaadEGI enabled auto-merge (squash) July 7, 2023 09:35
…tus' into feat/164-Visualize_Connector_Status

# Conflicts:
#	fake-backend/json/brokerConnectorPage.json
#	src/app/component-library/property-grid/property-grid/property-grid.component.html
#	src/app/routes/broker-ui/catalog-page/data-offer-cards/data-offer-cards.component.html
#	src/app/routes/broker-ui/connector-page/connector-cards/connector-cards.component.html
…tus' into feat/164-Visualize_Connector_Status
…-Visualize_Connector_Status

# Conflicts:
#	src/app/component-library/property-grid/property-grid/property-grid.component.ts
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should unify the icons as a component

import {Component, Input} from '@angular/core';
import {
  CatalogDataOfferConnectorOnlineStatusEnum,
  ConnectorDetailPageResultOnlineStatusEnum,
  ConnectorListEntryOnlineStatusEnum,
  DataOfferDetailPageResultConnectorOnlineStatusEnum,
} from '@sovity.de/broker-server-client';

@Component({
  selector: 'contract-offer-icon',
  template: `
    <!-- Icon -->
    <mat-icon class="mat-icon-[40px]">{{ icon }}</mat-icon>
  `,
})
export class IconWithOnlineStatusComponent {
  @Input()
  icon!: string;

  @Input()
  onlineStatus!:
    | CatalogDataOfferConnectorOnlineStatusEnum
    | ConnectorListEntryOnlineStatusEnum
    | DataOfferDetailPageResultConnectorOnlineStatusEnum
    | ConnectorDetailPageResultOnlineStatusEnum;
}

src/styles.scss Outdated Show resolved Hide resolved
SaadEGI and others added 4 commits July 10, 2023 18:22
…tus' into feat/164-Visualize_Connector_Status

# Conflicts:
#	src/app/component-library/catalog/status-icon/status-icon.component.ts
#	src/app/routes/broker-ui/catalog-page/data-offer-cards/data-offer-cards.component.html
#	src/app/routes/broker-ui/connector-page/connector-cards/connector-cards.component.html
@richardtreier richardtreier force-pushed the feat/164-Visualize_Connector_Status branch from 0b8577b to 604f6b8 Compare July 12, 2023 08:30
@richardtreier richardtreier force-pushed the feat/164-Visualize_Connector_Status branch from 604f6b8 to e90a655 Compare July 12, 2023 08:31
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Saad, I added some changes. Thus I disabled auto merge. I approved it, so you can review my additional changes first, and then merge the branch, if they check out.

@SaadEGI SaadEGI merged commit e214fc7 into main Jul 12, 2023
9 checks passed
@SaadEGI SaadEGI deleted the feat/164-Visualize_Connector_Status branch July 12, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Visualize Connector Status
2 participants