Skip to content

Commit

Permalink
Merge pull request #161 from sparcs-kaist/chore@return-to-original-pa…
Browse files Browse the repository at this point in the history
…ckage

Rollback dropdown_button2 to original package
  • Loading branch information
sboh1214 authored Oct 5, 2023
2 parents e261a5b + ec2d993 commit 8d8e412
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 12 deletions.
4 changes: 2 additions & 2 deletions lib/widgets/dropdown.dart
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ class Dropdown<T> extends StatelessWidget {
: null,
),
menuItemStyleData: MenuItemStyleData(
height: 42,
padding: EdgeInsets.zero,
),
items: items.map((itemData) {
Expand All @@ -91,8 +90,9 @@ class Dropdown<T> extends StatelessWidget {
),
),
];
return DropdownMenuItem<T>(
return DropdownItem<T>(
value: itemData.value,
height: 42,
child: Stack(
alignment: AlignmentDirectional.bottomStart,
children: [
Expand Down
11 changes: 5 additions & 6 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,11 @@ packages:
dropdown_button2:
dependency: "direct main"
description:
path: "."
ref: HEAD
resolved-ref: "81499508deb9fea0e54eeee82283e073fb0c96f4"
url: "https://github.com/sparcs-kaist/dropdown_button2.git"
source: git
version: "2.3.7"
name: dropdown_button2
sha256: a60c69cfe075b3b57cbecf163e629e05a5ac7057b9659494f6b80c1960fc7426
url: "https://pub.dev"
source: hosted
version: "3.0.0-beta.4"
easy_localization:
dependency: "direct main"
description:
Expand Down
5 changes: 1 addition & 4 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,11 @@ dependencies:
open_app_file: ^4.0.2
flutter_native_splash: ^2.3.2
mailto: ^2.0.0
dropdown_button2: ^3.0.0-beta.4
# Firebase
firebase_core: ^2.8.0
firebase_analytics: ^10.1.6
firebase_crashlytics: ^3.0.17
# Forked
dropdown_button2:
git:
url: https://github.com/sparcs-kaist/dropdown_button2.git

dev_dependencies:
test: ^1.19.5
Expand Down

0 comments on commit 8d8e412

Please sign in to comment.