Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login feature to Zabo Boards #9

Merged
merged 10 commits into from
May 5, 2024
Merged

Add login feature to Zabo Boards #9

merged 10 commits into from
May 5, 2024

Conversation

jinho-choi123
Copy link
Contributor

@jinho-choi123 jinho-choi123 commented Mar 18, 2024

Solve #8

  1. 백엔드에서 구현한 로그인 API와 연동
  2. 로그인 창 구현 - 사용자에게 보여지는 부분이 아니라서 디자인을 고려하지 않음. 다만 로그인 문제 발생시 에러 표시는 함.

추후 해결해야 할 이슈

  • 자보 보드에서 zabos을 모두 소진한 경우, 한 텀을 쉬었다가 다시 진행합니다(그동안 zabo fetch). 한 텀 쉬는 것을 없애는 것을 작업해야 할 것 같습니다.

Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 빠르세요 ㄷㄷ 작업해주셔서 감사드립니다!! 학기 초부터 고생 많으셨어요 :)
몇가지 제안을 첨부드립니다! 감사합니다.

.eslintrc.json Show resolved Hide resolved
src/redux/auth/loginThunk.ts Outdated Show resolved Hide resolved
src/redux/zabos/fetchZaboThunk.ts Outdated Show resolved Hide resolved
src/components/Auth/Auth.tsx Outdated Show resolved Hide resolved
Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우왕 피드백 빠르게 반영해주셔서 감사드립니다!! 오히려 제가 늦었어요..ㅎㅎ
좋아 보입니다!

@jinho-choi123 jinho-choi123 merged commit c5308e0 into develop May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants