Add reflected SH support for MirrorGaussian scenes - #411
Draft
katjaschwarz wants to merge 1 commit into
Draft
Conversation
Expose an object-space SH view basis on SplatMesh and apply it across packed, extended, and paged splat sources. Add a manifest-driven multi-mirror example that synchronizes real, reflection, and mask passes while navigating. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
The descriptions reference a Since you appear to be loading dedicated mirror and mask splat files anyway, wouldn't it make more sense to mirror the SH ahead of time? And even if mirrored at runtime, wouldn't it be an option to mirror the SH before evaluating? Not saying I'm against the idea of handling it at the SH evaluation stage, but then I'd rather make the SH evaluation pluggable/extendable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SplatMeshfor reflected spherical-harmonic evaluation.Why
MirrorGaussian reflects Gaussian geometry across each mirror plane, but view-dependent color also needs the corresponding reflection applied to the SH view direction. Without this transform, reflected geometry has incorrect view-dependent appearance.
How
SplatMeshexposes ashViewBasismatrix and passes it into every directional splat fetch path before SH evaluation. The example loads one reflected scene and mask per manifest mirror, waits for each Spark renderer to sort against the same camera snapshot, and composites the resulting render targets. It disables LOD in the example because independently updated LOD trees can put the passes at different camera states.Test plan
npm run lintnpm testnpm run buildMade with Cursor