Call super.dispose() in Object3D subclasses for Three.js r186 - #413
Open
mrxz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few descendant classes of Object3D in Spark that have their own
disposemethod. In the upcoming r186 release of Three.js, the base class will have adisposemethod as well, so derived classes should call it (see mrdoob/three.js#34141).This PR adds conditional calls to the base
disposemethod if present. This way the same code will work for the currently supported Three.js versions as well as the upcoming r186 and later. Since the types don't know about this newdisposemethod the@ts-ignoreannotations are required.