Fix layout bug and add tests #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
phschaad
commented
Jul 14, 2023
•
phschaad
commented
- Adds tests using the testing framework Jest
- Tests the integrated graph library
- Adds some tests for the vertical layout (specifically, the ranking phase)
- Fixes a few bugs detected through testing, including mishandling of self-loops
- Ensure the vertical layout doesn't get stuck if it fails due to some reason
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
Coverage ? 90.73%
=========================================
Files ? 7
Lines ? 820
Branches ? 155
=========================================
Hits ? 744
Misses ? 59
Partials ? 17 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tbennun
reviewed
Jul 19, 2023
| } | ||
|
|
||
| public get length(): number { | ||
| return this._nodes.size; |
| @@ -121,7 +125,7 @@ export class Graph<NodeT, EdgeT> implements GraphI<NodeT, EdgeT> { | |||
| } | |||
|
|
|||
| public numberOfEdges(): number { | |||
| return this.edges().length; | |||
| return this.edges().length / 2; | |||
| test( | ||
| 'Nested loops with fused assignment and condition edges', | ||
| testNestedLoopsFusedEdes | ||
| ); |
There was a problem hiding this comment.
Please add a test for a self edge loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.