-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
October Improvements 1/2 #117
Conversation
Please provide a screenshot here :) |
I'd also use a gray color myself. However, we may have discussed using that for non-leaf memlets just to emphasize that they do not generate code. |
I agree with this, but as you pointed out the gray is already going to be (most likely) occupied. Do you have a suggestion of what other style we could use? I agree that the color should ideally also differ. |
This looks good. Maybe no arrowhead would make that difference. You need it connected, not moving. In that case, maybe the line can even stay solid..? Unsure |
Good idea, I'll make that change |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tasklet highlighter might be slow for long codes but that should not be the default case. We may want to consider a length cutoff where we just draw the contents.
We should observe, a cutoff would be easy to add if necessary. The length of the tasklet code itself should not have a noticeable impact, only tasklets with dozens of in/out connectors each could potentially pose a challenge in my view. |
The example below shows both an empty memlet (top), as well as the current style of WCR edges (bottom) and how they differ in the visualization.