Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October Improvements 1/2 #117

Merged
merged 5 commits into from
Oct 23, 2023
Merged

October Improvements 1/2 #117

merged 5 commits into from
Oct 23, 2023

Conversation

phschaad
Copy link
Collaborator

@phschaad phschaad commented Oct 18, 2023

@tbennun
Copy link
Contributor

tbennun commented Oct 18, 2023

Please provide a screenshot here :)

@tbennun
Copy link
Contributor

tbennun commented Oct 18, 2023

I'd also use a gray color myself. However, we may have discussed using that for non-leaf memlets just to emphasize that they do not generate code.

@phschaad
Copy link
Collaborator Author

I'd also use a gray color myself. However, we may have discussed using that for non-leaf memlets just to emphasize that they do not generate code.

I agree with this, but as you pointed out the gray is already going to be (most likely) occupied. Do you have a suggestion of what other style we could use? I agree that the color should ideally also differ.

@phschaad phschaad changed the title Visualize empty memlets (i.e., dependency edges) as dotted lines October Improvements Oct 18, 2023
@phschaad phschaad changed the title October Improvements October Improvements 1/2 Oct 18, 2023
@phschaad phschaad requested a review from tbennun October 18, 2023 13:10
@tbennun
Copy link
Contributor

tbennun commented Oct 18, 2023

This looks good. Maybe no arrowhead would make that difference. You need it connected, not moving. In that case, maybe the line can even stay solid..? Unsure

@phschaad
Copy link
Collaborator Author

This looks good. Maybe no arrowhead would make that difference. You need it connected, not moving.

Good idea, I'll make that change

@phschaad
Copy link
Collaborator Author

This looks good. Maybe no arrowhead would make that difference. You need it connected, not moving. In that case, maybe the line can even stay solid..? Unsure

Done

Copy link
Contributor

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tasklet highlighter might be slow for long codes but that should not be the default case. We may want to consider a length cutoff where we just draw the contents.

@phschaad
Copy link
Collaborator Author

Looks good. Tasklet highlighter might be slow for long codes but that should not be the default case. We may want to consider a length cutoff where we just draw the contents.

We should observe, a cutoff would be easy to add if necessary. The length of the tasklet code itself should not have a noticeable impact, only tasklets with dozens of in/out connectors each could potentially pose a challenge in my view.

@phschaad phschaad merged commit 7442786 into master Oct 23, 2023
2 checks passed
@phschaad phschaad deleted the empty_memlet_viz branch October 23, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants