Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

May Improvements #147

Merged
merged 4 commits into from
May 27, 2024
Merged

May Improvements #147

merged 4 commits into from
May 27, 2024

Conversation

phschaad
Copy link
Collaborator

@phschaad phschaad commented May 27, 2024 •
edited
Loading

  • Add node separation to the settings
  • Improve settings menu
  • Improve rendering of edge summarization for two subsequent scope nodes
  • Minor formatting / typing fixes
  • Change panning bounds to minimap viewport instead of graph bounding box

@phschaad phschaad requested a review from tbennun May 27, 2024 15:01
tbennun
tbennun approved these changes May 27, 2024
View reviewed changes
src/overlays/avg_parallelism_overlay.ts
@@ -282,13 +288,12 @@ export class AvgParallelismOverlay extends GenericSdfgOverlay {
type: string,
_ev: Event,
_mousepos: Point2D,
_elements: SDFGElement[],
foreground_elem: SDFGElement,
_elements: Record<SDFGElementGroup, GraphElementInfo[]>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a record?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A common supertype for dictionaries, (hash-)maps, etc. - in this case it's used to make a 'typed' dictionary where keys cannot be arbitrary strings, but of a specific set of strings (indicated by the type 'SDFGElementGroup')

src/renderer/renderer_elements.ts
@@ -2183,8 +2236,8 @@ export class Tasklet extends SDFGNode {

public text_for_find(): string {
// Include code when searching
const code = this.attributes().code.string_data;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) oops

@phschaad phschaad merged commit 0367d50 into master May 27, 2024
2 checks passed
@phschaad phschaad deleted the may_fixes branch May 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phschaad @tbennun