Reorient view during relayout based on visible elements #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relayout now tries to keep track of the visible elements from before relayouting. This should allow more fluid transition when collapsing elements.
…w positions on the relayouted graph
phschaad
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Cool feature, looks good to me - thanks!
One thing I am slightly unsure about is whether the behavior should be something you can toggle on/off. I am thinking about it from a standpoint of 'consistency', in the sense that we are doing something that a user did not directly do (i.e., moving and potentially zooming without explicit action from the user other than collapse/expand). Maybe a user should be able to disable that if they find it irritating/confusing - despite it probably helping most users? Thoughts?
phschaad
pushed a commit
that referenced
this pull request
Sep 4, 2024
Relayout now tries to keep track of the visible elements from before relayouting. This should allow more fluid transition when collapsing elements. The heuristic condition is: every node that was entirely visible before the relayouting should still be visible after it. If they are all already visible, no changes are made to the view (we would like to minimize involuntary view changes as much as possible). Additionally, if a specific element instigated the change (i.e., a node was collapsed), it will also be included in the nodes to view. The PR also fixes a visual artifact introduced wherein collapsed nodes still appear for a few frames with their old coordinates, which results in a badly-drawn graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relayout now tries to keep track of the visible elements from before relayouting. This should allow more fluid transition when collapsing elements. The heuristic condition is: every node that was entirely visible before the relayouting should still be visible after it. If they are all already visible, no changes are made to the view (we would like to minimize involuntary view changes as much as possible).
Additionally, if a specific element instigated the change (i.e., a node was collapsed), it will also be included in the nodes to view.
The PR also fixes a visual artifact introduced wherein collapsed nodes still appear for a few frames with their old coordinates, which results in a badly-drawn graph.