Various Bugfixes #179
Merged
Various Bugfixes #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
phschaad
commented
Oct 30, 2024
•
phschaad
commented
- Fix exporting to PDF (Closes Exporting stopped working #177)
- Fix arrays and views not showing up in the info sidebar (Closes View/Reference properties no longer show up in sidebar #156)
- Fix Jupyter not being able to correctly initialize the viewer. Note that this is only part of the fix on the side of the viewer, the other half of the fix needs to be done in DaCe itself with a separate PR to update the distributed viewer there (Closes Jupyter broke again #168)
- Ensure SDFGs with irreducible control flow, which are not fully laid out by the SM Layouter do not crash the renderer by forcibly laying out unrouted edges with straight lines between the connecting nodes.
- Ensure access nodes accessing struct members are not shown as invalid / unknown data descriptor
Closes #177
tbennun
approved these changes
Oct 30, 2024
github-merge-queue bot
pushed a commit
to spcl/dace
that referenced
this pull request
Oct 31, 2024
This requires spcl/dace-webclient#179 to be merged before being ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.