Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Data Proposal (SDFG only) #1324

Merged
merged 46 commits into from
Aug 22, 2023
Merged

Nested Data Proposal (SDFG only) #1324

merged 46 commits into from
Aug 22, 2023

Conversation

alexnick83
Copy link
Contributor

@alexnick83 alexnick83 commented Jul 19, 2023

This PR implements the Nested Data proposal only for the SDFG IR (no frontend support).

…to the corresponding dtypes.struct typeclass.
dace/data.py Outdated Show resolved Hide resolved
@alexnick83 alexnick83 marked this pull request as ready for review August 17, 2023 13:59
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No design issues

dace/codegen/targets/cpp.py Show resolved Hide resolved
dace/codegen/targets/cpu.py Show resolved Hide resolved
dace/data.py Outdated Show resolved Hide resolved
dace/data.py Outdated Show resolved Hide resolved
dace/data.py Outdated Show resolved Hide resolved
dace/properties.py Outdated Show resolved Hide resolved
dace/codegen/targets/cpu.py Outdated Show resolved Hide resolved
dace/codegen/targets/cpu.py Show resolved Hide resolved
dace/codegen/targets/cpu.py Show resolved Hide resolved
dace/codegen/targets/cpu.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexnick83 alexnick83 merged commit f99bbca into master Aug 22, 2023
9 checks passed
@alexnick83 alexnick83 deleted the nested-data-sdfg branch August 22, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants