Work Depth Analysis for SDFGs #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2023
phschaad
requested changes
Jul 21, 2023
dace/sdfg/propagation.py
Outdated
| if state in full_merge_states: | ||
| state.dynamic_executions = False | ||
| # TODO: do we need this else here or not? | ||
| # else: |
There was a problem hiding this comment.
Yes there are some situations where this may be needed. Consider an if-else state machine which merges back into some common state mergestate, but where one of the branches may terminate the program based on some additional condition. In this case mergestate is not a full merge state, since there are program paths that may not reach it. In that case, the number of executions is dynamic, i.e. in [0:state.executions].
|
|
||
| def count_depth_reduce(node, symbols, state): | ||
| # depth of reduction is log2 of the work | ||
| # TODO: Can we actually assume this? Or is it equal to the work? |
|
|
||
|
|
||
| def tasklet_depth(tasklet_node, state): | ||
| # TODO: how to get depth of CPP tasklets? |
There was a problem hiding this comment.
Will be tricky, but for now I think it's fair to reduce analysis capabilites for those tasklets. We do this in general currently.
phschaad
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds work depth analysis of SDFGs. It includes three files:
work_depth.py: The analysis itself.helpers.py: Helper functions used by the analysis.work_depth_tests.py: Some small test SDFGs for the analysis.This PR is one of three PRs. They include: