-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Dependency Analysis for Control Flow Regions #1716
Draft
phschaad
wants to merge
99
commits into
main
Choose a base branch
from
users/phschaad/cf_block_data_deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,903
−2,478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- StateFusionExtended - ArrayElimination - OptionalArrayInference
This is _just_ a proposal.
Because of the removed filtering, `B` is now part of the read set as well.
Because of the removed filtering `B` is no longer removed from the read set. However, because now the test has become quite useless. We also see that the test was specifically constructed in such a way that the filtering applies. Otherwise it would never triggered.
Because of the removed filtering `B` is no longer removed from the read set. However, because now the test has become quite useless. We also see that the test was specifically constructed in such a way that the filtering applies. Otherwise it would never triggered.
…n_a_map`. Because the filtering is now not applied, like it was originally, the transformation does no longer apply. However, this is the historical expected behaviour.
Because of the removed filtering the transformat can no longer apply. However, I originally added these tests to demonstrate this inconsistent behaviour in the first place. So removing them is now the right choice. This commit also combines them to `prune_connectors_test.py::test_read_write`.
Ensured that the return value is always accassable in the same way. Also ensured that the `test_rna_read_and_write_sets_different_storage()` test verifies that it still gives the same result.
…oule_use` I realized that the transformation should not apply. The reason is because of all arguments to the nested SDFG element `0` is accessed. This means it can not be adjusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.