Set blob content type to disable detection #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
blob-content-type
branch
from
4b6904c
to
27fa7d6
Compare
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior in Golang is to try to detect the content type is no header is set. This adds a small bit of over head. For manifests we return the correct content type in the header as it is required by the distribution spec. The spec does not however mention any guidelines for what to do for setting the blobs content type.
https://github.com/opencontainers/distribution-spec/blob/main/spec.md#pulling-blobs
For this reason we will just set the header to a generic
application/octet-streamwhich is what is already being set today.