Skip status response verification for containerd v2 #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfroy
force-pushed
the
containerv2-workaround
branch
from
996d000
to
47f94b7
Compare
smbonn2005
added a commit
to smbonn2005/HomeOps
that referenced
this pull request
Sep 23, 2024
|
@jfroy could you rebase and add an entry to the changelog and we should be ok to merge. |
Codecov ReportAttention: Patch coverage is
|
Sure thing, will do later tonight (PST). |
Signed-off-by: Jean-Francois Roy <jf@devklog.net>
jfroy
force-pushed
the
containerv2-workaround
branch
from
47f94b7
to
e2ccf67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containerd v2 refactored its config structures/objects and the configuration that spegel is verifying in
verifyStatusResponseis no longer returned. This patch adds a version check toVerifyto allow spegel to skip the verification and take it on blind faith that it is configured correctly to work.Fixes #579