Fix Containerd host mirror ordering #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
fix/containerd-order
branch
3 times, most recently
from
2ead975
to
761e6e9
Compare
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
fix/containerd-order
branch
from
761e6e9
to
a23c341
Compare
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the use of toml un-marshalling with Go templating which was previously used a year ago. This is to make sure the the order the mirrors passed to Spegel are preserved in the toml file.
This change is heavily based on @vflaux work in both #550 and #557. Thank you for doing the research to figure out a path forward in solving this!
Fixes #549