-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snippets): disable sidebar collapse/expand when clicking "Your Library" @Dynamic Left Sidebar
#821
Open
Ender-Wang
wants to merge
29
commits into
spicetify:main
Choose a base branch
from
Ender-Wang:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all sides have equal margins.
A New Hover Panel that servers the same purpose as the legacy 'Hover Panels', but only for the left sidebar and without modifying any other elements.
Makes the left sidebar dynamic, so it only shows when you hover over it and pushes the main content to the right.
- caused by applying `white-space: nowrap` globally, now it only apply on `white-space` inside the left sidebar
…brary" @`Dynamic Left Sidebar`
…o` @ `Dynamic Left Sidebar`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I disabled the pointer action on
Your Library
, which removed the clicking ability onYour Library
, so the side bar will not be like this:But if someone uses
betterLibrary
too, s/he will not be able to click 'Your Library', hence I made another version that works withbetterLibrary
.